chore: replace remaining prompts #21218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
Twixes
reviewed
Apr 2, 2024
| success: actions.saveAsNamingSuccess, | ||
| initialValues: { name: `${values.insight.name || values.insight.derived_name} (copy)` }, | ||
| content: ( | ||
| <LemonField name="name"> |
There was a problem hiding this comment.
This should be name="insight-name" or something like that. With just "name", autocomplete (such as 1Password's) think this input refers to a person's name.
I see now there's a number of Field name="name" cases in our codebase, we should resolve these too at some point
Twixes
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow on from #21204
Towards #13624
Changes
Replace all remaining instances of the
promptLogicDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Direct replacements