feat(hogql): move default execution time to 120sec #21212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
approved these changes
Mar 28, 2024
Twixes
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Well, I'm now not so sure this is fine even if compatible with old behavior – I'm debugging a customer issue right now (ZEN-11735), which is exactly about legacy trends queries being killed after 60s due to our gateway timeout on Cloud US 😅 So I don't think anything over ~55s (accounting for overhead) is feasible anyway without async querying
|
Fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The legacy trends have a 120sec timeout. Several HogQL queries for our team time out at 60 seconds, but they pass for the old ones.
Changes
Equalise timeouts, hopefully equalise test results.
How did you test this code?
CI