Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add project path to action webhook urls #21211

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

benjackwhite
Copy link
Contributor

Problem

Fixes one issue from #21190 regarding urls not including the project

Changes

  • Adds the project part of the path to urls

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

✅ Updated tests

Copy link
Contributor

@tiina303 tiina303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️ btw feel free to use team review for pipeline team in the future as the reviewer,

@tiina303 tiina303 force-pushed the fix/webhook-links branch from a4ed62f to 75aa8eb Compare April 2, 2024 11:14
@tiina303 tiina303 merged commit 0c0a82d into master Apr 2, 2024
77 checks passed
@tiina303 tiina303 deleted the fix/webhook-links branch April 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants