feat(product-analytics): Use sessions table for session duration #21208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what's up with the tests here. I had the same thing happen #21197 when I made the branch, but this no longer seemed to be an issue after the next commits... 🤔 |
|
I got the tests green by making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're doing a slow join over the events table when we can do a fast join over the sessions table!
Changes
Do the fast join over the sessions table! Approach borrowed from the pdi table.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added some tests, and existing tests that test session duration still need to pass