Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renaming and moving snapshot loading #21207

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Mar 28, 2024

Problem

Towards #20632

Changes

Doing some of the simpler renaming / moving of code in a separate PR

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Should have no impact on tests

@daibhin daibhin requested a review from a team March 28, 2024 12:56
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question but otherwise :shipit:

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@daibhin daibhin merged commit 668ea16 into master Mar 28, 2024
83 checks passed
@daibhin daibhin deleted the dn-chore/renaming-and-moving-snapshot branch March 28, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants