Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): no_persons poe mode #21202

Closed
wants to merge 1 commit into from
Closed

feat(hogql): no_persons poe mode #21202

wants to merge 1 commit into from

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Mar 28, 2024

Problem

We want to support personless events.

Changes

Adds a new PoE mode no_persons that just blanks out all person properties and IDs. This doesn't make them null completely, but gives a zero UUID value. So you will see 1 user when any user was active, and 0 users when no users were active.

To enable it locally, modify these lines:

if modifiers.personsOnEventsMode is None:
if team.person_on_events_v3_querying_enabled:
modifiers.personsOnEventsMode = PersonsOnEventsMode.v3_enabled
else:
modifiers.personsOnEventsMode = team.person_on_events_mode

We might want an empty '{}' for properties instead of the null to not have everything fail, but it's a start.

How did you test this code?

Just locally in the /debug page for now.

Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants