Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve signup checkmark alignment #21188

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

zlwaterfield
Copy link
Contributor

Problem

The alignment of the signup check marks is off

Changes

before after
Screenshot 2024-03-27 at 11 20 12 AM Screenshot 2024-03-27 at 11 21 51 AM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

it doesn't have an impact

@zlwaterfield zlwaterfield self-assigned this Mar 27, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@zlwaterfield zlwaterfield enabled auto-merge (squash) March 27, 2024 18:25
@zlwaterfield zlwaterfield merged commit ed58302 into master Mar 27, 2024
136 checks passed
@zlwaterfield zlwaterfield deleted the fix-signup-checkmark-alignment branch March 27, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants