Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toolbar include params #21182

Merged
merged 4 commits into from
Mar 27, 2024
Merged

fix: toolbar include params #21182

merged 4 commits into from
Mar 27, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Mar 27, 2024

follow-up to #21180
which reverted #21178
which followed #21097

🫠

the elements stats API allows ?include=a&include=b as a way to pass multiple includes
kea's URL fangling doesn't support that type of URL

let's lean into that and change the API so that it supports both ?include=a&include=b for older clients and include=["a", "b"] for newer clients

changes the default for the API to include rageclicks and autocapture since that's what toolbar wants and nothing else uses this API

much simpler that way since we don't need any query params

@pauldambra pauldambra requested review from benjackwhite and a team March 27, 2024 10:04
Copy link
Contributor

github-actions bot commented Mar 27, 2024

Size Change: -49 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB -49 B (0%)

compressed-size-action

@pauldambra pauldambra merged commit 0d11b57 into master Mar 27, 2024
135 of 136 checks passed
@pauldambra pauldambra deleted the fix/toolbar-include-params branch March 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants