Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting --max-tasks-per-child on celery worker #21163

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Mar 26, 2024

Problem

This is so we can try to stop worker memory usage growing over time

image 📈

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@frankh frankh changed the title Allow setting --max-tasks-per-child on celery worker feat: Allow setting --max-tasks-per-child on celery worker Mar 26, 2024
This is so we can try to stop worker memory usage growing over time
@frankh frankh force-pushed the frank/celery-memory-options branch from a1787c7 to 3b31c48 Compare March 26, 2024 15:40
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea

@benjackwhite
Copy link
Contributor

That said I wonder is this because of some runaway long running tasks?

Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@frankh frankh merged commit 7148e2c into master Mar 26, 2024
127 of 128 checks passed
@frankh frankh deleted the frank/celery-memory-options branch March 26, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants