Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add frameworks to onboarding part 3 #21158

Conversation

Lior539
Copy link
Contributor

@Lior539 Lior539 commented Mar 26, 2024

Added more frameworks to onboarding:

  • Django
  • Vue
  • Webflow
  • Svelte

@Lior539 Lior539 requested a review from raquelmsmith March 26, 2024 12:25
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Size Change: 0 B

Total Size: 821 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 821 kB

compressed-size-action

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🙌

I'm assuming you'll get a merge conflict with this and #21091

@Lior539 Lior539 force-pushed the add-frameworks-to-onboarding-part-3 branch from 9fe89c5 to 9f04fbd Compare April 2, 2024 12:36
@Lior539 Lior539 merged commit e27dbe1 into add-frameworks-to-onboarding-part-2 Apr 2, 2024
12 of 16 checks passed
@Lior539 Lior539 deleted the add-frameworks-to-onboarding-part-3 branch April 2, 2024 12:36
Lior539 added a commit that referenced this pull request Apr 2, 2024
* astro

* add bubble

* framer

* laravel

* nuxt

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* add remix

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx

* feat: Add frameworks to onboarding part 3 (#21158)

* svelte

* missing export

* export

* webflow

* vue

* django

* flag code

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Raquel Smith <[email protected]>
Lior539 added a commit that referenced this pull request Apr 2, 2024
* astro

* add bubble

* framer

* laravel

* nuxt

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* add remix

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx

* feat: Add frameworks to onboarding part 3 (#21158)

* svelte

* missing export

* export

* webflow

* vue

* django

* flag code

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Raquel Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants