Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hogql): remove unsupported extract(..from..) #21157

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Mar 26, 2024

Problem

Fixes #21029

Changes

Removes the parsed yet unimplemented extract(a from b) syntax.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added a test. If we ever add the extract from syntax, the test will make sure the function keeps working.

@posthog-bot
Copy link
Contributor

It looks like the code of hogql-parser has changed since last push, but its version stayed the same at 1.0.3. 👀
Make sure to resolve this in hogql_parser/setup.py before merging!

@mariusandra mariusandra requested review from a team and Twixes March 26, 2024 14:43
@mariusandra
Copy link
Collaborator Author

@Twixes any clue what to do with the failing buildjet here? disable?

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like something went wrong when the PostHog/hog-rs repo was being set up, and hence BuildJet was only allowed on that one in our organization (it's a GitHub app). Added this repo back

Code looks good

@mariusandra mariusandra temporarily deployed to pypi-hogql-parser March 27, 2024 14:59 — with GitHub Actions Inactive
@mariusandra mariusandra merged commit a661b4b into master Mar 27, 2024
132 checks passed
@mariusandra mariusandra deleted the extract-hogql branch March 27, 2024 16:05
bretthoerner added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract function is not working as expected
3 participants