Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-server): add property for anonymized created_at #21143

Closed
wants to merge 1 commit into from

Conversation

bretthoerner
Copy link
Contributor

@bretthoerner bretthoerner commented Mar 25, 2024

Problem

Some customers really don't want accurate timestamps in their data, and these created_at ones were totally out of their control.

Changes

Add $truncate_created_at property which truncates to the day.

I'm actually not in love with adding this based on a single customer request. Magical properties easily become long-term maintenance burdens. Should the customer write a plugin for this, and then we check for a created_at field on the event instead of hardcoding now()?

Is it safe to give users control over that field? I actually don't know if there is product fallout from "breaking" created_at, I'm assuming it's just a debug column... but if it's a debug column for us, then giving them control will make it very confusing.

Does this work well for both Cloud and self-hosted?

Yes.

How did you test this code?

Unit test.

@bretthoerner bretthoerner requested a review from tiina303 March 25, 2024 22:07
@bretthoerner
Copy link
Contributor Author

@tiina303 Curious for your thoughts, related to Zendesk 11991

@bretthoerner
Copy link
Contributor Author

I changed it to truncate and it feels way less ugly now.

Now my main question is:

  1. Should it really just be $truncate_timestamps and apply to the timestamp field, too? (They do this themselves currently, but it feels like anyone who wants this feature would want it for all datetimes)
  2. Still unsure if it should be a magical property or become a full plugin type thing. Magical property feels a little less ugly if we think other people will actually use this.

@bretthoerner
Copy link
Contributor Author

Have plans to hide these from the UI instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant