fix(experiments): clean query nodes for experiment insights #21128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're planning to start rolling out HogQL funnel insights today. The new query endpoint is quite strict when validating the Pydantic schema of queries and does not allow additional properties. Since the
updateQuerySource
action merges the new query with any existing query, this can lead to invalid states e.g. when switching from trends to funnels in a new experiment:Repro:
Changes
This PR remove the
trendsFilter
when changing to a funnels query and vice-versa.How did you test this code?
Tried switching between trends and funnels for experiment metrics and secondary metrics locally