Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-analytics): Sessions table backfill: Make printing counts beforehand optional #21123

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

robbie-c
Copy link
Member

Problem

The query just to print the counts can take a long time, it's useful for debugging but make it optional

Changes

Make it optional

Does this work well for both Cloud and self-hosted?

Yes but unlikely to be relevant

How did you test this code?

Ran locally

@robbie-c robbie-c force-pushed the make-printing-counts-optional branch from 30d6184 to 81a945e Compare March 24, 2024 16:36
@robbie-c robbie-c marked this pull request as ready for review March 24, 2024 16:39
@robbie-c robbie-c enabled auto-merge (squash) March 24, 2024 16:40
@robbie-c robbie-c disabled auto-merge March 24, 2024 17:11
@robbie-c robbie-c merged commit 064f175 into master Mar 24, 2024
88 checks passed
@robbie-c robbie-c deleted the make-printing-counts-optional branch March 24, 2024 21:29
Copy link

sentry-io bot commented Mar 31, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ CHQueryErrorTooManyParts: Code: 252. posthog.clickhouse.client.execute in sync_execute View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant