feat: mobile replay onboarding #21122
Conversation
frontend/src/scenes/onboarding/sdks/product-analytics/android.tsx
Outdated
Show resolved
Hide resolved
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +102 B (0%) Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| ${ | ||
| includeReplay | ||
| ? ` | ||
| config.sessionReplay = true |
There was a problem hiding this comment.
Should we just point to this link though https://posthog.com/docs/session-replay/mobile#installation?
There are a few nuances such as limitations, the PostHogOkHttpInterceptor bits, etc, so they'd have more context on how it works and less code duplication here.
There was a problem hiding this comment.
added a code comment with a note... definitely something we can come back to to improve though 👍
| `/onboarding/${productKey}${stepKey ? '?step=' + stepKey : ''}`, | ||
| onboarding: (productKey: string, stepKey?: OnboardingStepKey, sdk?: SDKKey): string => | ||
| `/onboarding/${productKey}${stepKey ? '?step=' + stepKey : ''}${ | ||
| sdk && stepKey ? '&sdk=' + sdk : sdk ? '?sdk=' + sdk : '' |
There was a problem hiding this comment.
Awesome idea, thanks for adding this.
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
When we release android replay we'll want to let people know during onboarding
This adds a flag to control two changes
(fly-by let's you load the onboarding step on a particular SDK so we could link directly to the android onboarding for replay)