Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update PersonDistinctIdOverridesTable to be consistent with updated LazyTable interface #21113

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: Update PersonDistinctIdOverridesTable to be consistent with updated LazyTable interface #21113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions posthog/hogql/database/schema/person_distinct_id_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
)
from posthog.hogql.database.schema.persons import join_with_persons_table
from posthog.hogql.errors import HogQLException
from posthog.schema import HogQLQueryModifiers

PERSON_DISTINCT_ID_OVERRIDES_FIELDS = {
"team_id": IntegerDatabaseField(name="team_id"),
Expand Down Expand Up @@ -82,7 +81,7 @@ def to_printed_hogql(self):
class PersonDistinctIdOverridesTable(LazyTable):
fields: Dict[str, FieldOrTable] = PERSON_DISTINCT_ID_OVERRIDES_FIELDS

def lazy_select(self, requested_fields: Dict[str, List[str | int]], modifiers: HogQLQueryModifiers):
def lazy_select(self, requested_fields: Dict[str, List[str | int]], context: HogQLContext, node: SelectQuery):
return select_from_person_distinct_id_overrides_table(requested_fields)

def to_printed_clickhouse(self, context):
Expand Down
Loading