Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Toolbar better auth issue #21096

Merged
merged 5 commits into from
Mar 22, 2024
Merged

fix: Toolbar better auth issue #21096

merged 5 commits into from
Mar 22, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Mar 22, 2024

Problem

When the toolbar gets logged out its super unclear.

Changes

2024-03-22 11 09 58

  • Adds an authenticate button so its really obvious
  • Changes the logic to detect 401 always and trigger the logout
  • Removes some old code

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

  • Manually broke the temporary token locally so that we get the 401 message and validated it worked as expected.

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

frontend/src/toolbar/bar/Toolbar.tsx Show resolved Hide resolved
frontend/src/toolbar/toolbarConfigLogic.ts Outdated Show resolved Hide resolved
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: +125 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB +125 B (0%)

compressed-size-action

@benjackwhite benjackwhite merged commit d5cc9e4 into master Mar 22, 2024
93 checks passed
@benjackwhite benjackwhite deleted the toolbar-better-auth-issue branch March 22, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants