Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid text node should not render #21093

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

pauldambra
Copy link
Member

Screenshot 2024-03-22 at 00 19 34

spotted we were rendering the text undefined

the recording in question has an invalid text node - no text property

we have to render the ID in case future mutations affect it - but let's not render the empty text

Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@pauldambra pauldambra merged commit e5bec12 into master Mar 22, 2024
87 checks passed
@pauldambra pauldambra deleted the fix/not-undefined-in-replay-text branch March 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant