chore: improve mobile signup page #21090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated52 snapshot changes in total. 0 added, 52 modified, 0 deleted:
Triggered by this commit. |
…to improve-mobile-signup
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated52 snapshot changes in total. 0 added, 52 modified, 0 deleted:
Triggered by this commit. |
|
I'm not entirely sure why all the snapshots were regenerated, the images look identical. |
xrdt
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Is it expected that the colors are inverted here?
There was a problem hiding this comment.
It looks like the dark mode snapshots are generally looking a bit strange.
xrdt
approved these changes
Mar 22, 2024
Agree, I'll add it to my list to look into. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Improving the mobile styling for the signup form