feat: add a/b test for customer logos on signup page #21086
Conversation
zlwaterfield
changed the title
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -16 B (0%) Total Size: 824 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Can we confirm the logos look good on dark mode, as well? If you're going to add the logos, I suppose we should have storybook snapshots for each variation of the feature flag.
There was a problem hiding this comment.
Turns out auto pages are not dark mode friendly. See if statement here: https://github.com/PostHog/posthog/blob/master/frontend/src/layout/navigation-3000/themeLogic.ts#L28-L34. I'll look into that more but we can ignore for now.
Co-authored-by: Bianca Yang <[email protected]>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
Add a new a/b test building upon the current generic-signup-benefits with:
(new one updated to only run on desktop/tablet)
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
TODOs
Does this work well for both Cloud and self-hosted?
it doesn't have an impact