Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Update rows synced for all integrations #21077

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • We were only updating the rows_synced column in the data jobs for Stripe, and doing so in a non-atomic manner, meaning that the count could be set wrong as we're grabbing different Stripe data

Changes

  • Use DLT normalize stage to get the total synced rows for setting in the DB at the end of the pipeline

An example of a Zendesk job with no zendesk-specific code to set the count:
image

How did you test this code?

  • Updated unit test

@Gilbert09 Gilbert09 requested a review from EDsCODE March 21, 2024 15:46
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@Gilbert09 Gilbert09 removed the stale label Apr 2, 2024
@Gilbert09 Gilbert09 merged commit 6960a43 into master Apr 2, 2024
77 checks passed
@Gilbert09 Gilbert09 deleted the tom/job-rows-synced branch April 2, 2024 12:52
Copy link

sentry-io bot commented Apr 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ PipelineStepFailed: Pipeline execution failed at stage extract when processing package 1712195376.8302445 with except... dlt.pipeline.pipeline in extract View Issue
  • ‼️ PipelineStepFailed: Pipeline execution failed at stage extract when processing package 1712214182.7007186 with except... dlt.pipeline.pipeline in extract View Issue
  • ‼️ PipelineStepFailed: Pipeline execution failed at stage extract when processing package 1712245210.976281 with exception: dlt.pipeline.pipeline in extract View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants