Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Frontend support for file_format in S3 batch export #21076

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,15 @@ export function BatchExportsEditFields({
]}
/>
</LemonField>

<LemonField name="file_format" label="Format" className="flex-1">
<LemonSelect
options={[
{ value: 'JSONLines', label: 'JSON lines' },
{ value: 'Parquet', label: 'Apache Parquet' },
]}
/>
</LemonField>
</div>

<div className="flex gap-4">
Expand Down
1 change: 1 addition & 0 deletions frontend/src/scenes/batch_exports/BatchExports.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export default {
include_events: [],
encryption: null,
kms_key_id: null,
file_format: 'JSONLines',
},
},
start_at: null,
Expand Down
1 change: 1 addition & 0 deletions frontend/src/scenes/batch_exports/batchExportEditLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const batchExportFormFields = (
aws_secret_access_key: isNew ? (!config.aws_secret_access_key ? 'This field is required' : '') : '',
compression: '',
encryption: '',
file_format: isNew ? (!config.file_format ? 'This field is required' : '') : '',
kms_key_id: !config.kms_key_id && config.encryption == 'aws:kms' ? 'This field is required' : '',
exclude_events: '',
include_events: '',
Expand Down
1 change: 1 addition & 0 deletions frontend/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3597,6 +3597,7 @@ export type BatchExportDestinationS3 = {
encryption: string | null
kms_key_id: string | null
endpoint_url: string | null
file_format: string
}
}

Expand Down
Loading