feat: don't clone replay event data #21074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://posthog.slack.com/archives/C0374DA782U/p1711031505674169?thread_ts=1711030142.540499&cid=C0374DA782U
@benjackwhite do you remember why we clone?
we reducing events so that every session in a batch handled by a consumer is represented by a single message
becomes
in doing that we clone each object, but the
events
array can be largeIf we do not access the original array of messages after reducing then i think it's safe to reduce without cloning at all.
(looking at usage we parse each message into an array variable and then reduce those parsed messages into the array variable used elsewhere in the code so I think it's safe to not copy here)