Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hogql): Allow missing aggregate errors to reach the UI #21070

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(hogql): Allow missing aggregate errors to reach the UI #21070

merged 1 commit into from
Mar 21, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • When using an aggregate function that's not supported by HogQL, we hide the real error and show the user an unhelpful generic error
  • Reported by Annika here
image

Changes

  • Allow the aggregate error to reach the user

image

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

  • Via SQL queries

@Gilbert09 Gilbert09 requested a review from a team March 21, 2024 13:18
@Gilbert09 Gilbert09 merged commit 4c4a3fc into master Mar 21, 2024
127 of 128 checks passed
@Gilbert09 Gilbert09 deleted the tom/fix-agg-errors branch March 21, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilbert09 @mariusandra