Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): Format actors modal date labels #21069

Merged
merged 12 commits into from
Mar 24, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

Actor modals just use date value and it could be nicer with a label

Changes

  • use existing date label format function
  • improve some types, we can pass datetime to the frontend as it is, it will be turned into JSON nicely
image

Does this work well for both Cloud and self-hosted?

It should

How did you test this code?

  • checked tests and frontend

@webjunkie webjunkie requested review from mariusandra and a team March 21, 2024 12:54
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Just a test that seems related is failing.

@webjunkie webjunkie enabled auto-merge (squash) March 22, 2024 10:14
Copy link
Contributor

Size Change: +47 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB +47 B (0%)

compressed-size-action

@webjunkie webjunkie merged commit 37f3ff3 into master Mar 24, 2024
93 checks passed
@webjunkie webjunkie deleted the feature/actors-modal-date-labels branch March 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants