Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-warehouse): Adds a Zendesk integration #21068

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Conversation

Gilbert09
Copy link
Member

Problem

  • We want Zendesk data in our data warehouse

Changes

  • Uses DLTs "verified source" example as the base for the integration
    • Changed how the endpoints are loaded in slightly to fit in with other integrations we've already built
  • Loads the "base resources" and some basic support resources. The code is set up to support a bunch more endpoints/resources, but these are not enabled just yet
    • This integration also supports Zendesk Talk and Zendesk Chat, but I've not enabled these sources yet
  • Supports the API key mechanism for authing against Zendesk. It would be good to add the OAuth route soon too, but this was the easiest/quickest to set up
  • Updates the "Link Source" modal and backend to support linking Zendesk

How did you test this code?

  • Tested locally with syncing zendesk data from our support account

@Gilbert09 Gilbert09 requested a review from EDsCODE March 21, 2024 12:32
Copy link
Contributor

github-actions bot commented Mar 21, 2024

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@@ -1,9 +1,13 @@
from posthog.temporal.data_imports.pipelines.zendesk.settings import BASE_ENDPOINTS, SUPPORT_ENDPOINTS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: prefix these with ZENDESK. I could see other integrations getting written as BASE_ENDPOINTS too

@Gilbert09 Gilbert09 merged commit cbe486f into master Mar 21, 2024
133 of 135 checks passed
@Gilbert09 Gilbert09 deleted the tom/zendesk branch March 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants