fix(hogql): properly handle dst transition for funnel conversion window #21042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
hogql-funnel-window-dst
branch
from
86f09ce to
1053fde
Compare
thmsobrmlr
force-pushed
the
hogql-funnel-window-dst
branch
from
1053fde to
eeed68d
Compare
|
I'm YOLOing this fix for flagged code, so that I can get another round of testing in. Would appreciate comments though & will address in a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a funnel insight spans over a DST transition calculations like
+ INTERVAL 14 DAYSwould come up one hour short/long, since the timestamps are "timezone aware".Changes
Converting them to UTC before the addition mitigates the problem.
How did you test this code?
Added tests for everything except exclusions and the correlation events query