Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: padding reset for mobile replay #21041

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix: padding reset for mobile replay #21041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffb5955
fix: padding reset for mobile replay
pauldambra Mar 20, 2024
a6b5d61
fix
pauldambra Mar 20, 2024
0eeb0a5
updat snapshot
pauldambra Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions ee/frontend/mobile-replay/__snapshots__/transform.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ exports[`replay/transform transform can convert images 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -214,6 +215,7 @@ exports[`replay/transform transform can convert navigation bar 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -395,6 +397,7 @@ exports[`replay/transform transform can convert rect with text 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -551,6 +554,7 @@ exports[`replay/transform transform can convert status bar 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -718,6 +722,7 @@ exports[`replay/transform transform can ignore unknown wireframe types 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -860,6 +865,7 @@ exports[`replay/transform transform can process unknown types without error 1`]
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -1006,6 +1012,7 @@ exports[`replay/transform transform can set background image to base64 png 1`] =
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -1199,6 +1206,7 @@ exports[`replay/transform transform child wireframes are processed 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -1747,6 +1755,7 @@ exports[`replay/transform transform inputs buttons with nested elements 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -1913,6 +1922,7 @@ exports[`replay/transform transform inputs input - $inputType - hello 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2032,6 +2042,7 @@ exports[`replay/transform transform inputs input - button - click me 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2168,6 +2179,7 @@ exports[`replay/transform transform inputs input - checkbox - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2315,6 +2327,7 @@ exports[`replay/transform transform inputs input - checkbox - $value 2`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2461,6 +2474,7 @@ exports[`replay/transform transform inputs input - checkbox - $value 3`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2609,6 +2623,7 @@ exports[`replay/transform transform inputs input - checkbox - $value 4`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2740,6 +2755,7 @@ exports[`replay/transform transform inputs input - email - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -2871,6 +2887,7 @@ exports[`replay/transform transform inputs input - number - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3002,6 +3019,7 @@ exports[`replay/transform transform inputs input - password - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3133,6 +3151,7 @@ exports[`replay/transform transform inputs input - progress - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3289,6 +3308,7 @@ exports[`replay/transform transform inputs input - progress - $value 2`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3421,6 +3441,7 @@ exports[`replay/transform transform inputs input - progress - 0.75 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3553,6 +3574,7 @@ exports[`replay/transform transform inputs input - progress - 0.75 2`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3685,6 +3707,7 @@ exports[`replay/transform transform inputs input - search - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3816,6 +3839,7 @@ exports[`replay/transform transform inputs input - select - hello 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -3979,6 +4003,7 @@ exports[`replay/transform transform inputs input - tel - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4111,6 +4136,7 @@ exports[`replay/transform transform inputs input - text - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4242,6 +4268,7 @@ exports[`replay/transform transform inputs input - text - hello 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4373,6 +4400,7 @@ exports[`replay/transform transform inputs input - textArea - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4504,6 +4532,7 @@ exports[`replay/transform transform inputs input - textArea - hello 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4635,6 +4664,7 @@ exports[`replay/transform transform inputs input - toggle - $value 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4814,6 +4844,7 @@ exports[`replay/transform transform inputs input - toggle - $value 2`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -4993,6 +5024,7 @@ exports[`replay/transform transform inputs input - toggle - $value 3`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -5172,6 +5204,7 @@ exports[`replay/transform transform inputs input - toggle - $value 4`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -5335,6 +5368,7 @@ exports[`replay/transform transform inputs input - url - https://example.io 1`]
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -5466,6 +5500,7 @@ exports[`replay/transform transform inputs input gets 0 padding by default but c
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -6918,6 +6953,7 @@ exports[`replay/transform transform inputs placeholder - $inputType - $value 1`]
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -7053,6 +7089,7 @@ exports[`replay/transform transform inputs progress rating 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -7686,6 +7723,7 @@ exports[`replay/transform transform inputs radio group - $inputType - $value 1`]
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -7805,6 +7843,7 @@ exports[`replay/transform transform inputs radio_group - $inputType - $value 1`]
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -7934,6 +7973,7 @@ exports[`replay/transform transform inputs radio_group 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -8063,6 +8103,7 @@ exports[`replay/transform transform inputs web_view - $inputType - $value 1`] =
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -8198,6 +8239,7 @@ exports[`replay/transform transform inputs web_view with URL 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -8333,6 +8375,7 @@ exports[`replay/transform transform inputs wrapping with labels 1`] = `
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down Expand Up @@ -8480,6 +8523,7 @@ exports[`replay/transform transform omitting x and y is equivalent to setting th
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down
1 change: 1 addition & 0 deletions ee/frontend/mobile-replay/transformer/transformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,6 +1383,7 @@ function makeCSSReset(context: ConversionContext): serializedNodeWithId {
border: 0;
outline: 0;
background: transparent;
padding-block: 0 !important;
}
.input:focus {
outline: none;
Expand Down
Loading