feat: create playlists from errors #21037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
pauldambra
requested changes
Mar 20, 2024
| @@ -76,12 +76,12 @@ def construct_response(df: pd.DataFrame, team: Team, user: User): | |||
| clusters = [] | |||
| for cluster, rows in df.groupby("cluster"): | |||
| session_ids = rows["session_id"].unique() | |||
| sample = rows.sample(n=1)[["session_id", "input"]].rename(columns={"input": "error"}).to_dict("records") | |||
| sample = rows.sample(n=1)[["session_id", "input"]].rename(columns={"input": "error"}).to_dict("records")[0] | |||
There was a problem hiding this comment.
silly check do we know we have a non-empty thing to get [0] from at this point?
There was a problem hiding this comment.
Yep good question. The cluster will only be generated if it meets the MIN_SAMPLES so we know that each cluster has at least 10 rows
frontend/src/scenes/session-recordings/errors/sessionRecordingErrorsLogic.ts
Outdated
Show resolved
Hide resolved
marandaneto
approved these changes
Mar 21, 2024
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want users to be able to see a playlist of recordings containing a certain error
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
playlist.mp4