-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LemonDropdown width options #21035
Conversation
# Conflicts: # frontend/src/lib/components/PropertyFilters/components/PropertyValue.tsx
📸 UI snapshots have been updated12 snapshot changes in total. 0 added, 12 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
That's a good idea. Actually for simplicity, it may be best if |
Hmm yeah I can't actually see any good reason for having it be shorter than the parent... I'll do a different PR to keep the naming but with different behaviour |
Size Change: +138 B (0%) Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
LemonDropdown currently supports "sameWidth" but thats not always perfect. What often looks best is if the width is the same as the input but with the ability to grow if needed.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?