Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Fix set active view when changing insight #21034

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

When viewing a funnel insight and then clicking to use a funnel step as a start point in paths insight, the active view doesn't switch.

Changes

  • found only one way to do it: go via urlToAction
  • set the active view there
  • still doesn't work for query based insights/URLs because setActiveView will reset them, I got stock trying to invoke it

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

  • make funnel insight
  • click to use in paths
  • observe the insight tab changing, paths appear

@webjunkie webjunkie requested a review from thmsobrmlr March 20, 2024 10:20
Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webjunkie webjunkie merged commit 0c5b8cb into master Mar 20, 2024
134 of 135 checks passed
@webjunkie webjunkie deleted the fix/active-insight-nav branch March 20, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants