Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reverse proxy checker #21030

Merged
merged 13 commits into from
Mar 25, 2024
Merged

feat: add reverse proxy checker #21030

merged 13 commits into from
Mar 25, 2024

Conversation

zlwaterfield
Copy link
Contributor

Changes

Now that we are sending $lib_custom_api_host via the API, this adds a checker on the client to see if they have a proxy set as a helper function so we can show things in the UI based on it like a task in quick start or a callout notice on the feature flag page.

@zlwaterfield zlwaterfield self-assigned this Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@zlwaterfield zlwaterfield marked this pull request as ready for review March 20, 2024 03:54
@zlwaterfield zlwaterfield requested a review from a team March 20, 2024 03:54
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@xrdt xrdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should the title of the pr be: add reverse **proxy** checker

@zlwaterfield zlwaterfield changed the title feat: add reverse proper checker feat: add reverse proxy checker Mar 22, 2024
@@ -7,7 +7,7 @@ import { hogql } from '~/queries/utils'

import type { versionCheckerLogicType } from './versionCheckerLogicType'

const CHECK_INTERVAL_MS = 1000 * 60 * 60 // 6 hour
const CHECK_INTERVAL_MS = 1000 * 60 * 60 * 6 // 6 hour
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrectly set.

@zlwaterfield zlwaterfield merged commit fad9f5e into master Mar 25, 2024
134 checks passed
@zlwaterfield zlwaterfield deleted the reverse-proxy-check branch March 25, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants