-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reverse proxy checker #21030
Conversation
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should the title of the pr be: add reverse **proxy** checker
@@ -7,7 +7,7 @@ import { hogql } from '~/queries/utils' | |||
|
|||
import type { versionCheckerLogicType } from './versionCheckerLogicType' | |||
|
|||
const CHECK_INTERVAL_MS = 1000 * 60 * 60 // 6 hour | |||
const CHECK_INTERVAL_MS = 1000 * 60 * 60 * 6 // 6 hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was incorrectly set.
Changes
Now that we are sending
$lib_custom_api_host
via the API, this adds a checker on the client to see if they have a proxy set as a helper function so we can show things in the UI based on it like a task in quick start or a callout notice on the feature flag page.