Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): add field type on breakdown logic #21028

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Mar 20, 2024

Problem

  • after columns were changed to support both hogql and clickhouse types, the logic is wrong

Changes

  • add clickhouse specifier

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE merged commit 4073dc1 into master Mar 20, 2024
128 checks passed
@EDsCODE EDsCODE deleted the dw-virtual-data-warehouse-table-breakdowns-2 branch March 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant