Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow reads/writes to description without team collab feature #21027

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

raquelmsmith
Copy link
Member

Problem

If someone has dashboard descriptions saved, but no longer has the TEAM_COLLABORATION feature, trying to get this resource from the API would 403. However, the migration script depends on being able to read/write these descriptions, and we don't want to not migrate them because if the team wants them back at some point, re-migrating just these bits is a pain.

See: https://posthog.slack.com/archives/C043VJ93L3B/p1710161924625399

Changes

  • Allows read/writes of this field from the API.
  • No longer shows the description in the UI if they don't have the feature.
  • Modifies EditableField paywall functionality to use standard UpgradeModal instead of a different custom implementation

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

It should!

How did you test this code?

We may see some cypress failures here, if so I'll fix, if not I'll update.

@raquelmsmith raquelmsmith requested a review from a team March 20, 2024 00:34
Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@raquelmsmith raquelmsmith merged commit da97985 into master Mar 20, 2024
134 checks passed
@raquelmsmith raquelmsmith deleted the fix/team-collab-description-write branch March 20, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants