fix: allow reads/writes to description without team collab feature #21027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If someone has dashboard descriptions saved, but no longer has the
TEAM_COLLABORATION
feature, trying to get this resource from the API would 403. However, the migration script depends on being able to read/write these descriptions, and we don't want to not migrate them because if the team wants them back at some point, re-migrating just these bits is a pain.See: https://posthog.slack.com/archives/C043VJ93L3B/p1710161924625399
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It should!
How did you test this code?
We may see some cypress failures here, if so I'll fix, if not I'll update.