Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ingestion warning on old version #21025

Merged
merged 26 commits into from
Mar 28, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Mar 19, 2024

versions of the posthog-js SDK older than 1.75.0 are missing batching and ratelimiting improvements and can absolutely hammer ingestion

this PR:

  • starts emitting ingestion warnings when we see versions older than 1.75.0 (debounced by version and team)
  • sending a counter we can graph on our dashboard

@pauldambra pauldambra requested review from benjackwhite and a team March 19, 2024 23:49
Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but Ben probably has a lot more context on this part of the codebase

@pauldambra pauldambra requested a review from benjackwhite March 21, 2024 13:47
@pauldambra
Copy link
Member Author

"fun" tests that consistently pass locally fail in GH 🙃

@pauldambra pauldambra requested a review from benjackwhite March 28, 2024 14:02
@pauldambra
Copy link
Member Author

tested locally with an old posthog-js

Screenshot 2024-03-28 at 18 23 37

@pauldambra pauldambra merged commit 02c596c into master Mar 28, 2024
77 checks passed
@pauldambra pauldambra deleted the feat/ingestion_warning_on_old_version branch March 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants