-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): string breakdowns #21023
Conversation
…insight-moar-fixas
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this code super well but LGTM after ~10 min review, the described change makes sense
Thanks 🙌. Happy to update/revert if anyone has additional thoughts. I want to see if the changes here make a difference, so going to merge it in. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Problem
Breakdowns with "other", when the value is returned in a funny format, such as a list
['array of text']
, cause type errors when passing through thetransform(value, [['txt']], [['txt']], 'other')
function that adds the "other"The only reason I initially added
BREAKDOWN_NULL_NUMERIC_LABEL
vsBREAKDOWN_NULL_STRING_LABEL
was because not everything was returned as a string, and I wanted to preserve sorting when things were returned as numbers, and manually sorted. However other than strings, ints and floats, there are many other types of breakdown values that can be returned... arrays, tuples, bools, datetimes, etc.Changes
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?