Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove code for finished experiment #21018

Merged
merged 1 commit into from
Mar 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: remove code for finished experiment
pauldambra committed Mar 19, 2024

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra
commit 4ba33e318a62ee4e76d2836c9ba99275070a2200
36 changes: 0 additions & 36 deletions frontend/src/lib/components/Support/SupportForm.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { IconBug, IconInfo, IconQuestion } from '@posthog/icons'
import {
LemonBanner,
LemonInput,
LemonSegmentedButton,
LemonSegmentedButtonOption,
@@ -16,7 +15,6 @@ import { LemonField } from 'lib/lemon-ui/LemonField'
import { LemonFileInput } from 'lib/lemon-ui/LemonFileInput/LemonFileInput'
import { LemonSelect } from 'lib/lemon-ui/LemonSelect/LemonSelect'
import { LemonTextArea } from 'lib/lemon-ui/LemonTextArea/LemonTextArea'
import posthog from 'posthog-js'
import { useEffect, useRef } from 'react'
import { preflightLogic } from 'scenes/PreflightCheck/preflightLogic'
import { userLogic } from 'scenes/userLogic'
@@ -97,40 +95,6 @@ export function SupportForm(): JSX.Element | null {
<LemonField name="target_area" label="Topic">
<LemonSelect fullWidth options={TARGET_AREA_TO_NAME} />
</LemonField>
{posthog.getFeatureFlag('show-troubleshooting-docs-in-support-form') === 'test-replay-banner' &&
sendSupportRequest.target_area === 'session_replay' && (
<LemonBanner type="info">
<>
We're pretty proud of our docs. Check out these helpful links:
<ul>
<li>
<Link target="_blank" to="https://posthog.com/docs/session-replay/troubleshooting">
Session replay troubleshooting
</Link>
</li>
<li>
<Link
target="_blank"
to="https://posthog.com/docs/session-replay/how-to-control-which-sessions-you-record"
>
How to control which sessions you record
</Link>
</li>
</ul>
</>
</LemonBanner>
)}
{posthog.getFeatureFlag('show-troubleshooting-docs-in-support-form') === 'test-replay-banner' &&
sendSupportRequest.target_area === 'toolbar' && (
<LemonBanner type="info">
<>
We're pretty proud of our docs.{' '}
<Link target="_blank" to="https://posthog.com/docs/toolbar#troubleshooting-and-faq">
Check out this troubleshooting guide
</Link>
</>
</LemonBanner>
)}
<LemonField
name="message"
label={sendSupportRequest.kind ? SUPPORT_TICKET_KIND_TO_PROMPT[sendSupportRequest.kind] : 'Content'}

Unchanged files with check annotations Beta

</>
)}
{editable && updateColor && (
<LemonButtonWithDropdown

Check warning on line 154 in frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
dropdown={{
overlay: Object.values(InsightColor).map((availableColor) => (
<LemonButton
</LemonButtonWithDropdown>
)}
{editable && moveToDashboard && otherDashboards.length > 0 && (
<LemonButtonWithDropdown

Check warning on line 184 in frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
dropdown={{
overlay: otherDashboards.map((otherDashboard) => (
<LemonButton
</LemonButton>
{moveToDashboard && otherDashboards.length > 0 && (
<LemonButtonWithDropdown

Check warning on line 96 in frontend/src/lib/components/Cards/TextCard/TextCard.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
dropdown={{
overlay: otherDashboards.map((otherDashboard) => (
<LemonButton
)
return (
<LemonButtonWithDropdown

Check warning on line 209 in frontend/src/lib/components/DateFilter/DateFilter.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
data-attr="date-filter"
id="daterange_selector"
onClick={isVisible ? close : open}
}
return (
<LemonButtonWithDropdown

Check warning on line 33 in frontend/src/lib/components/ExportButton/ExportButton.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
ref={ref}
data-attr="export-button"
{...buttonProps}
onChange: (newValue: any, save: boolean) => void
}): JSX.Element {
return (
<Input

Check warning on line 49 in frontend/src/lib/components/PropertiesTable/PropertiesTable.tsx

GitHub Actions / Code quality checks

<Input> is forbidden, use <LemonInput> instead
defaultValue={value}
autoFocus
onBlur={() => onChange(null, false)}
}
}}
>
<Select

Check warning on line 152 in frontend/src/lib/components/SelectGradientOverflow.tsx

GitHub Actions / Code quality checks

<Select> is forbidden, use <LemonSelect> instead
{...props}
dropdownAlign={placement ? ANTD_TOOLTIP_PLACEMENTS[placement] : undefined}
ref={selectRef}
const { push } = useActions(router)
return (
<LemonButtonWithDropdown

Check warning on line 71 in frontend/src/lib/components/Subscriptions/SubscriptionsModal.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
fullWidth
dropdown={{
actionable: true,
onClose={() => setCustomUnitModal(null)}
overlayRef={(ref) => (customUnitModalRef.current = ref)}
/>
<LemonButtonWithDropdown

Check warning on line 94 in frontend/src/lib/components/UnitPicker/UnitPicker.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
onClick={() => setIsVisible(!isVisible)}
size="small"
type="secondary"
type PopoverStory = StoryObj<typeof LemonButtonWithDropdown>
const PopoverTemplate: StoryFn<typeof LemonButtonWithDropdown> = (props: LemonButtonWithDropdownProps) => {
return <LemonButtonWithDropdown {...props} />

Check warning on line 86 in frontend/src/lib/lemon-ui/LemonButton/LemonButton.stories.tsx

GitHub Actions / Code quality checks

<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
}
export const NoPadding = (): JSX.Element => {