chore: replace antd Select component in ObjectTags #20981
Conversation
📸 UI snapshots have been updated190 snapshot changes in total. 0 added, 190 modified, 0 deleted:
Triggered by this commit. |
daibhin
force-pushed
the
dn-chore/replace-tags
branch
from
e59a7d5 to
448ba37
Compare
📸 UI snapshots have been updated191 snapshot changes in total. 0 added, 191 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated236 snapshot changes in total. 0 added, 236 modified, 0 deleted:
Triggered by this commit. |
| @@ -329,7 +329,7 @@ describe('the activity log logic', () => { | |||
| const actual = logic.values.humanizedActivity | |||
|
|
|||
| expect(render(<>{actual[0].description}</>).container).toHaveTextContent( | |||
| 'peter added tags 4 5 , and removed tags 2 3 on test insight' | |||
| 'peter added tags 45, and removed tags 23 on test insight' | |||
There was a problem hiding this comment.
Believe this is just the new dom structure. Checked the stories and things still render nicely
📸 UI snapshots have been updated236 snapshot changes in total. 0 added, 236 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
📸 UI snapshots have been updated236 snapshot changes in total. 0 added, 236 modified, 0 deleted:
Triggered by this commit. |
Problem
Towards #13624
Since #20948 we have a new multiselect component
Changes
Replace custom
SelectGradientOverflowstyleSelectwith the newLemonInputSelectwhich has everything the old component offered already built inDebated making a
sizeattribute on theLemonInputSelectbut there is some drift between the size of the input & lemon snacks (snacks themselves don't have any size so would need to be added, and the close button size would not map directly to the input).Does this work well for both Cloud and self-hosted?
Nope!
How did you test this code?
tags.mp4