fix(insights): Remove connect logics for rename series #20972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pauldambra Would this work? The rename still works this way, I just used connect in my original PR since I thought it's cleaner. |
|
Size Change: 0 B Total Size: 821 kB ℹ️ View Unchanged
|
pauldambra
approved these changes
Mar 18, 2024
Comment on lines
+185
to
+188
| const dataLogic = insightDataLogic.findMounted({ | ||
| dashboardItemId: props.typeKey, | ||
| }) | ||
| dataLogic?.actions?.loadData(true) |
There was a problem hiding this comment.
looks safe to me... I guess the worst thing that happens is for some reason its not mounted and someone needs to refresh 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The logics shouldn't be connected directly, see #20942
Changes
How did you test this code?