chore: new icons preview #20957
Merged
chore: new icons preview #20957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.52 kB (0%) Total Size: 824 kB
|
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Twixes
approved these changes
Mar 19, 2024
Comment on lines
+55
to
+57
| <LemonCollapse | ||
| multiple | ||
| panels={Object.entries(group).map(([key, icons]) => { |
There was a problem hiding this comment.
Would be even more handy if the panels were expanded by default (using defaultActiveKeys), what do you think?
There was a problem hiding this comment.
I considered that originally but some of the categories were quite large and knocked the others off the page. Happy to follow up with it because I'm still undecided as to which is better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have a great way to see / find the new icons
Changes
Does this work well for both Cloud and self-hosted?
No impact
How did you test this code?
Test makes sure any new icons are also categorised