Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reverse proxy step to quick start steps + more quick start events #20939

Merged
merged 19 commits into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ const ActivationTask = ({
if (url) {
params.to = url
params.targetBlank = true
params.onClick = () => {
reportActivationSideBarTaskClicked(id)
}
} else {
params.onClick = () => {
runTask(id)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { actions, connect, events, kea, listeners, path, reducers, selectors } f
import { loaders } from 'kea-loaders'
import { router } from 'kea-router'
import api from 'lib/api'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { permanentlyMount } from 'lib/utils/kea-logic-builders'
import posthog from 'posthog-js'
import { membersLogic } from 'scenes/organization/membersLogic'
import { pluginsLogic } from 'scenes/plugins/pluginsLogic'
import { savedInsightsLogic } from 'scenes/saved-insights/savedInsightsLogic'
Expand All @@ -25,6 +25,7 @@ export enum ActivationTasks {
SetupSessionRecordings = 'setup_session_recordings',
TrackCustomEvents = 'track_custom_events',
InstallFirstApp = 'install_first_app',
SetUpReverseProxy = 'set_up_reverse_proxy',
}

export type ActivationTaskType = {
Expand Down Expand Up @@ -65,8 +66,6 @@ export const activationLogic = kea<activationLogicType>([
['loadPluginsSuccess', 'loadPluginsFailure'],
sidePanelStateLogic,
['openSidePanel'],
eventUsageLogic,
['reportActivationSideBarShown'],
zlwaterfield marked this conversation as resolved.
Show resolved Hide resolved
savedInsightsLogic,
['loadInsights', 'loadInsightsSuccess', 'loadInsightsFailure'],
dashboardsModel,
Expand Down Expand Up @@ -282,6 +281,17 @@ export const activationLogic = kea<activationLogicType>([
skipped: skippedTasks.includes(ActivationTasks.InstallFirstApp),
})
break
case ActivationTasks.SetUpReverseProxy:
tasks.push({
id: ActivationTasks.SetUpReverseProxy,
name: 'Set up a reverse proxy',
description: 'Send your events from your own domain to avoid tracking blockers',
completed: false,
canSkip: true,
skipped: skippedTasks.includes(ActivationTasks.SetUpReverseProxy),
url: 'https://posthog.com/docs/advanced/proxy',
})
break
default:
break
}
Expand Down Expand Up @@ -342,6 +352,9 @@ export const activationLogic = kea<activationLogicType>([
}
},
skipTask: ({ id }) => {
posthog.capture('activation sidebar task skipped', {
task: id,
})
if (values.currentTeam?.id) {
actions.addSkippedTask(values.currentTeam.id, id)
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { actions, kea, listeners, path, reducers } from 'kea'
import { actionToUrl, router, urlToAction } from 'kea-router'
import { windowValues } from 'kea-window-values'
import posthog from 'posthog-js'

import { SidePanelTab } from '~/types'

Expand Down Expand Up @@ -55,10 +56,12 @@ export const sidePanelStateLogic = kea<sidePanelStateLogicType>([
listeners(({ actions, values }) => ({
// NOTE: We explicitly reference the actions instead of connecting so that people don't accidentally
// use this logic instead of sidePanelStateLogic
openSidePanel: () => {
openSidePanel: ({ tab }) => {
posthog.capture('activation sidebar opened', { tab })
zlwaterfield marked this conversation as resolved.
Show resolved Hide resolved
actions.setSidePanelOpen(true)
},
closeSidePanel: ({ tab }) => {
posthog.capture('activation sidebar closed', { tab })
zlwaterfield marked this conversation as resolved.
Show resolved Hide resolved
if (!tab) {
// If we aren't specifiying the tab we always close
actions.setSidePanelOpen(false)
Expand Down
12 changes: 0 additions & 12 deletions frontend/src/lib/utils/eventUsageLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,11 +457,6 @@ export const eventUsageLogic = kea<eventUsageLogicType>([
reportInstanceSettingChange: (name: string, value: string | boolean | number) => ({ name, value }),
reportAxisUnitsChanged: (properties: Record<string, any>) => ({ ...properties }),
reportTeamSettingChange: (name: string, value: any) => ({ name, value }),
reportActivationSideBarShown: (
activeTasksCount: number,
completedTasksCount: number,
completionPercent: number
) => ({ activeTasksCount, completedTasksCount, completionPercent }),
reportActivationSideBarTaskClicked: (key: string) => ({ key }),
reportBillingUpgradeClicked: (plan: string) => ({ plan }),
reportRoleCreated: (role: string) => ({ role }),
Expand Down Expand Up @@ -1092,13 +1087,6 @@ export const eventUsageLogic = kea<eventUsageLogicType>([
value,
})
},
reportActivationSideBarShown: ({ activeTasksCount, completedTasksCount, completionPercent }) => {
posthog.capture('activation sidebar shown', {
active_tasks_count: activeTasksCount,
completed_tasks_count: completedTasksCount,
completion_percent_count: completionPercent,
})
},
reportActivationSideBarTaskClicked: ({ key }) => {
posthog.capture('activation sidebar task clicked', {
key,
Expand Down
Loading