Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show pricing section on unlicensed product intro #20914

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

raquelmsmith
Copy link
Member

Problem

Product intro pages have a pricing section, but it's not relevant for self-hosted as they can't upgrade there.

Changes

Hides it, which also avoids errors on this page.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@raquelmsmith raquelmsmith requested a review from a team March 13, 2024 21:29
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Size Change: 0 B

Total Size: 822 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 822 kB

compressed-size-action

Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this bug makes sense to me now!

Looks good 👍

@raquelmsmith raquelmsmith enabled auto-merge (squash) March 14, 2024 19:16
@raquelmsmith raquelmsmith merged commit d38b6fa into master Mar 14, 2024
80 checks passed
@raquelmsmith raquelmsmith deleted the fix/product-intro-unlicensed branch March 14, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants