Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-warehouse): virtual data warehouse table #20888

Merged
merged 20 commits into from
Mar 15, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Mar 13, 2024

Problem

  • implement data warehouse in insights using hogql rather than the query builder

Changes

  • add distinct_id mapping
  • change events to data warehouse table
  • add field mappings through the hogql modifier

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link

sentry-io bot commented Mar 13, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/hogql/database/database.py

Function Unhandled Issue
create_hogql_database Exception: Columns must be fetched and saved to use in HogQL. ee.tasks.replay.embed_batch_of_re...
Event Count: 13

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Size Change: 0 B

Total Size: 822 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 822 kB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@EDsCODE EDsCODE requested a review from Gilbert09 March 14, 2024 01:27
Copy link
Member

@Gilbert09 Gilbert09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it's looking good, I think this is a good direction

@EDsCODE EDsCODE marked this pull request as ready for review March 14, 2024 16:47
@EDsCODE EDsCODE requested a review from Gilbert09 March 14, 2024 20:37
Copy link
Member

@Gilbert09 Gilbert09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🚢

@EDsCODE EDsCODE merged commit 9f52e06 into master Mar 15, 2024
80 checks passed
@EDsCODE EDsCODE deleted the dw-virtual-data-warehouse-table branch March 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants