feat(persons-on-events): Support backfilling multiple teams, and store backfill state #20886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaemming
commented
Mar 13, 2024
Comment on lines
60
to
70
| updated_teams = list( | ||
| Team.objects.raw( | ||
| """ | ||
| UPDATE posthog_team | ||
| SET extra_settings = COALESCE(extra_settings, '{}'::jsonb) || jsonb_build_object('distinct_id_overrides_backfilled', true) | ||
| WHERE id = %s | ||
| RETURNING * | ||
| """, | ||
| [self.team_id], | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I had assumed there would be a more convenient way to update this via the ORM… not sure the "shortcut" was worth it at this point.
| @@ -14,10 +15,12 @@ | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class BackfillQuery: | |||
There was a problem hiding this comment.
This is a bit more than a Query at this point.
bretthoerner
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The backfill command previously wasn't convenient to use to run a mass backfill over all teams, e.g. as a Kubernetes
Job, or even just manually run from a toolbox pod.This allows it to be executed over all teams that have not already been marked as backfilled unless a specific
--team-idis provided. Tracking the state makes lets us make sure that no teams were missed, as well as prevents duplicate rows being unnecessarily inserted in case of repeat executions.How did you test this code?
The more important
Backfillwas already tested, manually tested the CLI variations.--team-id--team-id(including invalid team)