Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Part 1] Add more frameworks to onboarding - Angular #20868

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

Lior539
Copy link
Contributor

@Lior539 Lior539 commented Mar 12, 2024

This PR adds Angular to the onboarding flow. There's 11 more to add still, but I figured for the first PR best to keep small since it's easier to review in case I'm doing something wildly wrong.

There's 11 more to do still. The next PR will probably have 5 or so of them, and the following PR with the remainder

Frameworks to add:

  • Astro
  • Bubble
  • Django
  • Flask
  • Framer
  • Laravel
  • Remix
  • Svelte
  • Webflow
  • Nuxt
Screenshot 2024-03-13 at 12 01 35 PM

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Lior539 Lior539 requested a review from raquelmsmith March 13, 2024 12:08
@Lior539 Lior539 changed the title Add more frameworks to onboarding [Part 1] Add more frameworks to onboarding - Angular Mar 13, 2024
@Lior539 Lior539 self-assigned this Mar 13, 2024
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!! couple comments but otherwise LGTM

@Lior539 Lior539 changed the title [Part 1] Add more frameworks to onboarding - Angular feat: [Part 1] Add more frameworks to onboarding - Angular Mar 18, 2024
@Lior539 Lior539 force-pushed the add-frameworks-to-onboarding branch from 158453b to 4a50868 Compare March 19, 2024 11:24
@Lior539 Lior539 enabled auto-merge (squash) March 19, 2024 11:25
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Lior539 and others added 5 commits April 2, 2024 13:38
* astro

* add bubble

* framer

* laravel

* nuxt

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* add remix

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx

* feat: Add frameworks to onboarding part 3 (#21158)

* svelte

* missing export

* export

* webflow

* vue

* django

* flag code

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Raquel Smith <[email protected]>
@Lior539 Lior539 force-pushed the add-frameworks-to-onboarding branch from 33f30a5 to 53f5e53 Compare April 2, 2024 12:39
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Lior539 Lior539 merged commit 429c67d into master Apr 2, 2024
83 checks passed
@Lior539 Lior539 deleted the add-frameworks-to-onboarding branch April 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants