Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links and migrate to js-lite new major #20854

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Mar 12, 2024

Problem

Cont. PostHog/posthog.com#8021

  • changed the old links to the new links after redirect
  • node uses the new method.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@marandaneto marandaneto requested review from benjackwhite and a team March 12, 2024 11:06
@@ -13,7 +13,7 @@ function NodeCaptureSnippet(): JSX.Element {
// Send queued events immediately. Use for example in a serverless environment
// where the program may terminate before everything is sent.
// Use \`client.flush()\` instead if you still need to send more events or fetch feature flags.
client.shutdownAsync()`}
client.shutdown()`}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration is just here for node

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Size Change: 0 B

Total Size: 822 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 822 kB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@marandaneto marandaneto marked this pull request as ready for review March 18, 2024 09:44
@marandaneto marandaneto enabled auto-merge (squash) March 18, 2024 09:52
@marandaneto marandaneto merged commit 48d9c70 into master Mar 18, 2024
82 checks passed
@marandaneto marandaneto deleted the fix/links-migrate-js-lite-major branch March 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants