Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Serve staticfile direct from nginx unit #20777

Closed
wants to merge 1 commit into from

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Mar 8, 2024

Problem

We don't need to use django for staticfiles (even if there is a CDN in front)

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@frankh frankh added the deploy label Mar 8, 2024
@frankh frankh changed the title Serve staticfile direct from nginx unit feat: Serve staticfile direct from nginx unit Mar 8, 2024
@github-actions github-actions bot temporarily deployed to pr-frank/serve-static-unit March 8, 2024 10:34 Destroyed
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@frankh frankh force-pushed the frank/serve-static-unit branch from 5811e3a to b0ea76f Compare March 20, 2024 11:35
@github-actions github-actions bot temporarily deployed to pr-frank/serve-static-unit March 20, 2024 11:38 Destroyed
@posthog-bot posthog-bot removed the stale label Mar 21, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@frankh frankh force-pushed the frank/serve-static-unit branch from b0ea76f to 7da2743 Compare April 4, 2024 09:05
@github-actions github-actions bot temporarily deployed to pr-frank/serve-static-unit April 4, 2024 09:12 Destroyed
We don't need to use django for staticfiles (even if there is a CDN
in front)
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@frankh frankh added canary and removed stale labels Apr 16, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this May 2, 2024
@frankh frankh reopened this May 2, 2024
@frankh frankh removed the stale label May 2, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants