Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feature gating for activity panel and automatic provisioning #20771

Merged
merged 14 commits into from
May 6, 2024

Conversation

raquelmsmith
Copy link
Member

Problem

As a follow up to the Teams plan launch, we needed to add feature gating for:

  • Team activity side panel
  • Automatic provisioning
    • Technically Automatic provisioning !== adding a domain. But there is no point in adding a domain without automatic provisioning, SSO enforcement, or SAML. In the billing PR linked below I made sure that these features are included together.

This requires https://github.com/PostHog/billing/pull/479 to go live first

Changes

  • Blocks access to the Team activity side panel if they don't have the audit_logs feature.
    • image
  • Blocks access to the "Authentication Domains" section of the org settings page
    • image
  • Puts check in API to make sure people don't create domains if they don't have the feature

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Updated tests. I also removed tests for self-hosted because this shouldn't be available for self-hosted.

@raquelmsmith raquelmsmith requested a review from xrdt March 7, 2024 22:24
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@raquelmsmith raquelmsmith reopened this May 6, 2024
@raquelmsmith raquelmsmith force-pushed the feat/teams-feature-gating-pt-2 branch from 229fb1f to 43a5c3c Compare May 6, 2024 19:28
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@raquelmsmith raquelmsmith enabled auto-merge (squash) May 6, 2024 20:18
@raquelmsmith raquelmsmith disabled auto-merge May 6, 2024 20:23
@raquelmsmith raquelmsmith enabled auto-merge (squash) May 6, 2024 20:31
@raquelmsmith raquelmsmith merged commit f10c867 into master May 6, 2024
104 checks passed
@raquelmsmith raquelmsmith deleted the feat/teams-feature-gating-pt-2 branch May 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants