Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Debugging options for V3 ingester #20569

Merged
merged 4 commits into from
Feb 27, 2024
Merged

chore: Debugging options for V3 ingester #20569

merged 4 commits into from
Feb 27, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

Trying to debug the new ingester. We don't expose enough options to do that effectively.

Changes

  • Adds kafka ui locally (helps with testing different configurations)
  • Removes RECORDING_PARTITIONS_CONSUMED_CONCURRENTLY that isn't used
  • Adds SESSION_RECORDING_KAFKA_DEBUG so that we can conditionally turn on some logging

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite enabled auto-merge (squash) February 27, 2024 09:53
@benjackwhite benjackwhite requested a review from a team February 27, 2024 10:02
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benjackwhite benjackwhite merged commit 47b2882 into master Feb 27, 2024
75 checks passed
@benjackwhite benjackwhite deleted the fix/v3-ingester branch February 27, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants