Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): add remaining funnel actors #20496

Merged
merged 13 commits into from
Feb 26, 2024
Merged

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Feb 22, 2024

Problem

Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).

Changes

Adds the remaining funnel actors (except correlation) to HogQL.

How did you test this code?

Converted existing tests

@thmsobrmlr thmsobrmlr changed the title feat(hogql): add funnel strict actors feat(hogql): add remaining funnel actors Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Size Change: 0 B

Total Size: 815 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 815 kB

compressed-size-action

Base automatically changed from funnel-hogql-actors to master February 22, 2024 13:00
@thmsobrmlr thmsobrmlr mentioned this pull request Feb 22, 2024
48 tasks
@thmsobrmlr thmsobrmlr requested a review from a team February 22, 2024 14:12
# Conflicts:
#	posthog/hogql_queries/insights/test/__snapshots__/test_lifecycle_query_runner.ambr
#	posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends.ambr
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) February 26, 2024 08:13
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr merged commit da1d9fb into master Feb 26, 2024
80 checks passed
@thmsobrmlr thmsobrmlr deleted the funnel-strict-actors branch February 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants